Decode round from fitness and use it in getround for proposals#13
Merged
e-asphyx merged 1 commit intoecadlabs:v2from Feb 23, 2026
Merged
Decode round from fitness and use it in getround for proposals#13e-asphyx merged 1 commit intoecadlabs:v2from
e-asphyx merged 1 commit intoecadlabs:v2from
Conversation
Contributor
|
Thank you for the contribution Valentin! We will review/test. Much appreciated. |
jevonearth
added a commit
that referenced
this pull request
Mar 3, 2026
- Replace fmt.Println error swallowing with panic in BlockSignRequest.GetRound(), matching existing convention for impossible-state failures in consensus sign request methods. The previous behavior silently returned round 0 on error. - Tighten fitness length check from 4 to 33 bytes (minimum valid Tenderbake fitness without locked round). - Add tests with two real mainnet fitness vectors (proto_016 round 0, proto_024 round 1 reproposal) plus synthetic coverage for both fitness shapes and error rejection. Followup to #13.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋
I work at Nomadic Labs on Octez.
Some bakers recently missed slots, and after investigation we isolated the issue in Signatory: it was unable to sign reproposals (same payload at a higher round). This PR addresses that issue.
To test this patch I have setup a sandbox network with a signatory using this patch. I have tried to repropose with the same payload using
(
/tmp/tezos-client-signatoryis a client that uses remote keys from a signatory instance)Please let me know if you’d like any additional context or the full testing scenario.